Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[documentation] Remove RobotContainer from templates #7055

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[documentation] Remove RobotContainer from templates #7055

wants to merge 1 commit into from
+48 −207

Conversation

spacey-sooty
Copy link
Contributor

Removing from templates is waiting on #7054

@spacey-sooty spacey-sooty requested review from a team as code owners September 8, 2024 09:54
@spacey-sooty
Copy link
Contributor Author

/format

@spacey-sooty spacey-sooty force-pushed the remove-robotcontainer branch 2 times, most recently from 2a1b85a to 71fad19 Compare September 8, 2024 10:41
@spacey-sooty
Copy link
Contributor Author

/format

@PeterJohnson
Copy link
Member

We need to discuss whether removal of RobotContainer makes sense, especially that we're on the cusp of starting development on adding FTC support for 2027. FTC has something similar to RobotContainer in their current templates; I believe this because they need to keep hardware instantiated through all opmodes (which each look like variants of Robot.java). I don't want to remove it just to add it back in. So I believe we should wait on this and plan on having conversations regarding what we want the template approach to be across programs and style variations before diving into implementation changes.

@spacey-sooty
Copy link
Contributor Author

We need to discuss whether removal of RobotContainer makes sense, especially that we're on the cusp of starting development on adding FTC support for 2027. FTC has something similar to RobotContainer in their current templates; I believe this because they need to keep hardware instantiated through all opmodes (which each look like variants of Robot.java). I don't want to remove it just to add it back in. So I believe we should wait on this and plan on having conversations regarding what we want the template approach to be across programs and style variations before diving into implementation changes.

The current reason that I among others were interested in removing RobotContainer is because it doesn't add anything. You can achieve a completely functionally identical system by just instantiating things within Robot. I don't understand how FTC would change that for us; if you instantiate things in the constructor (or statically if you so desire) then you have the ability to keep them around for the lifetime of the class, RobotContainer doesn't add anything.

@spacey-sooty
Copy link
Contributor Author

https://discord.com/channels/176186766946992128/368993897495527424/1282509678647181335

It doesn't appear to me based off this conversation that this change will be affected by FTC at all

@spacey-sooty spacey-sooty force-pushed the remove-robotcontainer branch 2 times, most recently from 7c0f392 to 82ff3ca Compare September 9, 2024 02:11
@spacey-sooty
Copy link
Contributor Author

/format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calcmogul calcmogul calcmogul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spacey-sooty @PeterJohnson @calcmogul