Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Min-sizing for dataframes/arrays [no merge] #3189

Closed
wants to merge 18 commits into from

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Oct 17, 2024

Issue and/or context: As tracked on issue #2407 / [sc-51048].

Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.

Changes:

In the agreed-on design at #2407 we agreed that None no longer means "as big a domain as possible" but now rather "as small as possible". This is a breaking change we have already agreed on.

On this PR -- not to be merged -- I've made the mods to the dataframe/array classes as well as unit-test cases. The result is many many lines -- too many.

This PR will be split up into several pieces, and then ultimately abandoned. It is posted here at all (a) for transparency; (b) for a CI check; (c) for bus-factor avoidance.

Notes for Reviewer:

This PR will be split up into several pieces, and then ultimately abandoned. It is posted here at all (a) for transparency; (b) for a CI check; (c) for bus-factor avoidance.

@johnkerl
Copy link
Member Author

Replaced by #3203

@johnkerl johnkerl closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant