-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] Min-sizing for dataframes/arrays [no merge] #3189
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: As tracked on issue #2407 / [sc-51048].
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
In the agreed-on design at #2407 we agreed that
None
no longer means "as big a domain as possible" but now rather "as small as possible". This is a breaking change we have already agreed on.On this PR -- not to be merged -- I've made the mods to the dataframe/array classes as well as unit-test cases. The result is many many lines -- too many.
This PR will be split up into several pieces, and then ultimately abandoned. It is posted here at all (a) for transparency; (b) for a CI check; (c) for bus-factor avoidance.
Notes for Reviewer:
This PR will be split up into several pieces, and then ultimately abandoned. It is posted here at all (a) for transparency; (b) for a CI check; (c) for bus-factor avoidance.