Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Domain-at-create unit-test PR 1/5 #3191

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Oct 17, 2024

Issue and/or context: As tracked on issue #2407 / [sc-51048].

Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.

Changes:

Split out from #3189 as described there.

@johnkerl johnkerl changed the title [python] Domain-at-create unit-test PR 1/N [python] Domain-at-create unit-test PR 1/5 Oct 17, 2024
@johnkerl johnkerl requested a review from nguyenv October 17, 2024 19:18
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.30%. Comparing base (fddfd9a) to head (3e49623).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3191      +/-   ##
==========================================
+ Coverage   83.19%   83.30%   +0.10%     
==========================================
  Files          51       51              
  Lines        5504     5504              
==========================================
+ Hits         4579     4585       +6     
+ Misses        925      919       -6     
Flag Coverage Δ
python 83.30% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 83.30% <ø> (+0.10%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl marked this pull request as ready for review October 17, 2024 19:19
@johnkerl johnkerl force-pushed the kerl/py-domain-at-create-ut-1 branch from 8e12dec to 244d7d8 Compare October 18, 2024 01:09
@johnkerl johnkerl force-pushed the kerl/py-domain-at-create-ut-1 branch from 244d7d8 to 3e49623 Compare October 18, 2024 01:09
@johnkerl johnkerl merged commit a34f3fa into main Oct 18, 2024
11 checks passed
@johnkerl johnkerl deleted the kerl/py-domain-at-create-ut-1 branch October 18, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants