[c++] Methodize timestamped-schema-evolution factory #2909
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: This is a line-count-reducing under-diff split out from #2785 for issue #2407; [sc-51048].
Changes:
On #2895 I made an inline code block for instantiating an
ArraySchemaEvolution
object pointed at the current array's context and open-at timestamp (if any). That was after I did a call-graph analysis that showed that this was the sole spot inmain
-- at that point in time -- where we needed to do this.However, on #2785 we'll be making more use of schema evolution, from more than one callsite. It makes even more sense now to encapsulate this logic in a single place.
Notes for Reviewer: