Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++] Methodize timestamped-schema-evolution factory #2909

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Aug 17, 2024

Issue and/or context: This is a line-count-reducing under-diff split out from #2785 for issue #2407; [sc-51048].

Changes:

On #2895 I made an inline code block for instantiating an ArraySchemaEvolution object pointed at the current array's context and open-at timestamp (if any). That was after I did a call-graph analysis that showed that this was the sole spot in main -- at that point in time -- where we needed to do this.

However, on #2785 we'll be making more use of schema evolution, from more than one callsite. It makes even more sense now to encapsulate this logic in a single place.

Notes for Reviewer:

Copy link

codecov bot commented Aug 17, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 59.52%. Comparing base (bdba3c3) to head (4a16241).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2909       +/-   ##
===========================================
- Coverage   89.88%   59.52%   -30.37%     
===========================================
  Files          37       92       +55     
  Lines        3925    11337     +7412     
  Branches        0      724      +724     
===========================================
+ Hits         3528     6748     +3220     
- Misses        397     4418     +4021     
- Partials        0      171      +171     
Flag Coverage Δ
libtiledbsoma 43.36% <50.00%> (?)
python 90.03% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 90.03% <ø> (+0.15%) ⬆️
libtiledbsoma 50.00% <50.00%> (∅)

@johnkerl johnkerl merged commit 95cd876 into main Aug 19, 2024
14 of 15 checks passed
@johnkerl johnkerl deleted the kerl/schevo-timestamp-methodize branch August 19, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants