[c++] Remove some dead code in int64-only shape accessor #2915
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: Found at https://github.com/single-cell-data/TileDB-SOMA/pull/2911/files#r1721037749 on PR #2911, for issue #2407 / [sc-51048].
Changes:
We were capable of returning incorrect information for arrays which do not have
int64_t
dimensions. However, passing status on all Python/R-level unit tests shows that this is a safe and non-breaking change.Notes for Reviewer:
This PR should be approved and merged before #2911. Then #2915 can be rebased on top of the new
main
.