Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++] Remove some dead code in int64-only shape accessor #2915

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Aug 18, 2024

Issue and/or context: Found at https://github.com/single-cell-data/TileDB-SOMA/pull/2911/files#r1721037749 on PR #2911, for issue #2407 / [sc-51048].

Changes:

We were capable of returning incorrect information for arrays which do not have int64_t dimensions. However, passing status on all Python/R-level unit tests shows that this is a safe and non-breaking change.

Notes for Reviewer:

This PR should be approved and merged before #2911. Then #2915 can be rebased on top of the new main.

Copy link

codecov bot commented Aug 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.03%. Comparing base (6f88d57) to head (a65cbd7).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2915      +/-   ##
==========================================
+ Coverage   89.88%   90.03%   +0.15%     
==========================================
  Files          37       37              
  Lines        3925     3925              
==========================================
+ Hits         3528     3534       +6     
+ Misses        397      391       -6     
Flag Coverage Δ
python 90.03% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 90.03% <ø> (+0.15%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl
Copy link
Member Author

Thanks @nguyenv ! :)

@johnkerl johnkerl merged commit 08193f2 into main Aug 27, 2024
14 of 15 checks passed
@johnkerl johnkerl deleted the kerl/cpp-strict-int64-shape branch August 27, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants