Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r/python] Deprecation notices for used_shape #2834

Merged
merged 4 commits into from
Aug 5, 2024
Merged

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Aug 5, 2024

Issue and/or context: For #2407

Changes:

Notes for Reviewer:

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.22%. Comparing base (c931ffe) to head (8cdaef9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2834      +/-   ##
==========================================
+ Coverage   90.06%   90.22%   +0.15%     
==========================================
  Files          37       37              
  Lines        3937     3940       +3     
==========================================
+ Hits         3546     3555       +9     
+ Misses        391      385       -6     
Flag Coverage Δ
python 90.22% <0.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 90.22% <0.00%> (+0.15%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl marked this pull request as ready for review August 5, 2024 20:30
@@ -20,7 +20,8 @@
NPInteger = np.integer[npt.NBitBase]
NPFloating = np.floating[npt.NBitBase]
NPNDArray = npt.NDArray[np.number[npt.NBitBase]]
PDSeries = pd.Series[Any] # type: ignore[misc] # a pd.Series of "any" type will raise mypy error
# A pd.Series of "Any" type will raise mypy error:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR. Lint flared up today right here. IDK why.

@johnkerl johnkerl changed the title [r/python] Deprecation notices for used_shape [WIP] [r/python] Deprecation notices for used_shape Aug 5, 2024
@mojaveazure
Copy link
Member

For the R API, you could also call .Deprecated() in used_shape() to throw a deprecation warning when calling that method

@johnkerl
Copy link
Member Author

johnkerl commented Aug 5, 2024

We have some flakiness around (I think) the particular linter version available -- something bumped today -- lint passing on Python 3.8 and failing on Python 3.11, and it appears they cannot be both appeased simultaneously ...

@johnkerl johnkerl merged commit da466af into main Aug 5, 2024
12 of 14 checks passed
@johnkerl johnkerl deleted the kerl/shape-deprecations branch August 5, 2024 21:33
@johnkerl
Copy link
Member Author

johnkerl commented Aug 5, 2024

For the R API, you could also call .Deprecated() in used_shape() to throw a deprecation warning when calling that method

Oops @mojaveazure I meant to do that on this PR -- I'll put up another

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants