-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[r/python] Deprecation notices for used_shape
#2834
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2834 +/- ##
==========================================
+ Coverage 90.06% 90.22% +0.15%
==========================================
Files 37 37
Lines 3937 3940 +3
==========================================
+ Hits 3546 3555 +9
+ Misses 391 385 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -20,7 +20,8 @@ | |||
NPInteger = np.integer[npt.NBitBase] | |||
NPFloating = np.floating[npt.NBitBase] | |||
NPNDArray = npt.NDArray[np.number[npt.NBitBase]] | |||
PDSeries = pd.Series[Any] # type: ignore[misc] # a pd.Series of "any" type will raise mypy error | |||
# A pd.Series of "Any" type will raise mypy error: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not related to this PR. Lint flared up today right here. IDK why.
used_shape
[WIP]used_shape
For the R API, you could also call |
We have some flakiness around (I think) the particular linter version available -- something bumped today -- lint passing on Python 3.8 and failing on Python 3.11, and it appears they cannot be both appeased simultaneously ... |
Oops @mojaveazure I meant to do that on this PR -- I'll put up another |
Issue and/or context: For #2407
Changes:
Notes for Reviewer: