Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r] Use .Deprecated for used_shape in R #2835

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Aug 5, 2024

Follow-on from #2834 (comment) for issue #2407

Example interactive use:

> exp <- SOMAExperimentOpen('/var/p')

> exp$ms$get("RNA")$X$get("data")$used_shape()
$soma_dim_0
integer64
[1] 0    2637

$soma_dim_1
integer64
[1] 0    1837

Warning message:
used_shape will be removed in TileDB-SOMA 1.14

apis/r/R/TileDBArray.R Outdated Show resolved Hide resolved
Copy link
Member

@mojaveazure mojaveazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! .Deprecated() works by throwing warnings that are classed as deprecatedWarning; given that testthat will throw warnings if it catches warnings where they aren't expected (expect_warning()), I've added suppressions of deprecations in the tests in c52bdbf

@johnkerl
Copy link
Member Author

johnkerl commented Aug 5, 2024

TIL, thanks @mojaveazure !

@johnkerl johnkerl merged commit edabcb6 into main Aug 5, 2024
3 of 4 checks passed
@johnkerl johnkerl deleted the kerl/shape-deprecations-r branch August 5, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants