Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Full Windows pre-push CI matrix #1962

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Dec 6, 2023

#1811 added Windows support. Pre-push/minimal CI was green, but post-push/full CI was not -- see notes on #1959 -- hence the revert on #1959. Then #1961 restores #1811 to main but without Windows CI. This is the sweet spot: now we have the large Windows PR in main, with opt-in CI testing here on this PR. CC @teo-tsirpanis and @nguyenv .

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #1962 (625bc9c) into main (cf72782) will increase coverage by 0.27%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1962      +/-   ##
==========================================
+ Coverage   62.82%   63.10%   +0.27%     
==========================================
  Files         106      106              
  Lines       10043    10068      +25     
==========================================
+ Hits         6310     6353      +43     
+ Misses       3733     3715      -18     
Flag Coverage Δ
python 89.67% <ø> (+0.57%) ⬆️
r 48.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 89.67% <ø> (+0.57%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl
Copy link
Member Author

johnkerl commented Dec 7, 2023

@teo-tsirpanis feel free to push commits to this PR whenever 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants