[c++] Fix Windows build regressions and stop using deprecated TileDB APIs #2445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnkerl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: As part of validating that libtiledbsoma does not use deprecated TileDB APIs, I tried to build it on my Windows machine with a build of TileDB with all deprecated APIs removed from the headers. I encountered a couple of errors and this PR fixes them. I also migrated two deprecated API usages in the tests.
Changes: With an exception in two tests, we mostly replace constructs that caused errors for MSVC with constructs that do not. The deprecated API migration is very straightforward.
Validated by successfully building libtiledbsoma and
unit_somaon my local machine and running the tests. To prevent further regressions we should eventually work towards reenabling Windows CI in #1962.Notes for Reviewer: