Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest-merger fails with "FeatureName must follow" #814

Open
Hanmac opened this issue Apr 27, 2024 · 0 comments
Open

manifest-merger fails with "FeatureName must follow" #814

Hanmac opened this issue Apr 27, 2024 · 0 comments

Comments

@Hanmac
Copy link

Hanmac commented Apr 27, 2024

[ERROR] Failed to execute goal com.simpligility.maven.plugins:android-maven-plugin:4.6.0:manifest-merger (update-manifest) on project forge-gui-android: Execution update-manifest of goal com.simpligility.maven.plugins:android-maven-plugin:4.6.0:manifest-merger failed: FeatureName must follow [a-zA-Z0-9][a-zA-Z0-9_]* regex, found -> [Help 1]

there is the code:

builder.mergeManifestsForApplication(
androidManifestFile, // mainManifest
new ArrayList<File>(), // manifestOverlays
manifestDependencies, // libraries
"", // packageOverride
versionCode, // versionCode
parsedVersionName, // versionName
minSdkVersion, // minSdkVersion
targetSdkVersion, // targetSdkVersion
null, // maxSdkVersion

see this change in the android tools?

https://android.googlesource.com/platform/tools/base/+/bcfd5995fdd31ca4e32b315a29db09807e598e38%5E%21/build-system/builder/src/main/java/com/android/builder/core/AndroidBuilder.java

-    /**
-     * Invoke the Manifest Merger version 2.
-     */
+    /** Invoke the Manifest Merger version 2. */
     public MergingReport mergeManifestsForApplication(
             @NonNull File mainManifest,
             @NonNull List<File> manifestOverlays,
             @NonNull List<? extends ManifestProvider> dependencies,
+            @Nullable String featureName,
             String packageOverride,
             int versionCode,
             String versionName,

I don't know exactly what the featureName should be or if it should be null

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant