Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Fixes #1

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Initial Fixes #1

merged 2 commits into from
Aug 15, 2024

Conversation

kevlahnota
Copy link

No description provided.

@Hanmac
Copy link

Hanmac commented Aug 15, 2024

@tehdiplomat i think i'm going to merge this, and then can re try to make a new release out of it

@Hanmac Hanmac merged commit c564ff9 into master Aug 15, 2024
@tehdiplomat
Copy link

@Hanmac Do we need to update the snapshot script for new versions and things? Whats the plan?

@Hanmac
Copy link

Hanmac commented Aug 15, 2024

@tehdiplomat the snapshot script already uses the 4.6.1 Version:
https://github.com/Card-Forge/forge/blob/038374c3c5df334e1dcae40278723302ba5aea22/.github/workflows/snapshots-android.yml#L79-L80

so no changes needed

just the release for this Repo need to be build / updated again (maybe an Action for this repo too?)

@tehdiplomat
Copy link

Ah I think @kevlahnota had built that locally and I just uploaded it last time? An action to build the repo is probably a good idea. Should we be bumping the version number to 4.6.2? So we don't clubber the functioning release? I guess pom can handle that.

@Hanmac
Copy link

Hanmac commented Aug 15, 2024

yeah an Action would be cool

i'm not against bumping it

@tehdiplomat
Copy link

@kevlahnota How are you running this locally? Can we convert that into github actions here?

@kevlahnota
Copy link
Author

@kevlahnota How are you running this locally? Can we convert that into github actions here?

I run this
mvn clean install -DskipTests -e

I don't have experience using github actions so I don't know what to do with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants