-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android manifest update #4977
base: master
Are you sure you want to change the base?
Android manifest update #4977
Conversation
@Agetian maybe you know why on github we don't need to mess with the d8 file? |
Hmm, not sure tbh, I haven't investigated the Github way of doing things as far as building and deploying an Android snapshot goes ^^; |
@Agetian can you look to replace
that is one of the last pieces where the Version needs to be updated |
Hmm, getVersionString simply returns "GIT" for me (on a snapshot version), with the entire BuildInfo.class.getPackage() method returning "null"... Not sure if it would return a proper version string if executed on an actual release. At any rate, kinda confusing for snapshots as such. I wonder if there's a better way to track the number, hmm... |
Normally, maven should have put the version inside these Manifest files so it can be accessed by |
I think we need https://maven.apache.org/shared/maven-archiver/examples/manifest.html <configuration>
<archive>
<manifest>
<addDefaultImplementationEntries>true</addDefaultImplementationEntries>
</manifest>
</archive>
</configuration> i will check this out at weekend |
Sounds good! |
8af07b7
to
2c3f9c9
Compare
@Agetian the addDefaultImplementationEntries should already be enabled by default when i run As for the Android thing, i tried:
and i get:
but i can't find where the problem is happening (it is difficult to debug inside the maven plugin) |
This PR has not been updated in a while nad has been marked on stale. Stale PRs will be auto closed |
Linked Issue that is causing the problem: |
this moves the Android Manifest to the more Default Location for the plugins
and enables
manifest-merger
goal.This sets the VersionName and generates the VersionCode from it