Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Prevent accordion chevron from shrinking on smaller viewports #717

Merged
merged 3 commits into from
Jun 27, 2023
Merged

fix: Prevent accordion chevron from shrinking on smaller viewports #717

merged 3 commits into from
Jun 27, 2023

Conversation

FadyMak
Copy link
Contributor

@FadyMak FadyMak commented Jun 26, 2023 •
edited
Loading

Prevents the chevron icon of the accordion from shrinking on smaller viewports:

Before:

CleanShot 2023-06-26 at 09 10 02

After:

CleanShot 2023-06-26 at 09 11 25

@changeset-bot
Copy link

changeset-bot bot commented Jun 26, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 30e1b22

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jun 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-template ⬜️ Ignored (Inspect) Jun 26, 2023 0:57am

@vercel
Copy link

vercel bot commented Jun 26, 2023

@FadyMak is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@FadyMak FadyMak changed the title Prevent accordion chevron from shrinking on smaller viewports fix: Prevent accordion chevron from shrinking on smaller viewports Jun 26, 2023
dan5py
dan5py suggested changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@dan5py dan5py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to edit the New York theme's component and update the registry.
And other two things:

  • in TailwindCSS v3+ you should use shrink-0 instead of flex-shrink-0
  • the linter has a warning about the classnames order (place it after the w-4)

@FadyMak
Copy link
Contributor Author

FadyMak commented Jun 26, 2023

Thanks for the feedback @dan5py 🙇 I believe I've applied the requested changes if you wouldn't mind having a look when you get a chance.

and update the registry

For this, I ran the build:registry script -- I assume that's what you meant here. Please let me know otherwise.

dan5py
dan5py approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@dan5py dan5py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems all good now.

shadcn
shadcn approved these changes Jun 27, 2023
View reviewed changes
Copy link
Collaborator

@shadcn shadcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@shadcn shadcn merged commit a8bb2ef into shadcn-ui:main Jun 27, 2023
5 checks passed
@FadyMak FadyMak deleted the patch-1 branch June 27, 2023 07:42
This was referenced Jun 27, 2023
Closed
Closed
Closed
suleymanbariseser pushed a commit to suleymanbariseser/shadcn-ui that referenced this pull request Jul 25, 2023
@FadyMak @suleymanbariseser
fix(accordion): prevent accordion chevron from shrinking on smaller v…
191c8aa 
…iewports (shadcn-ui#717)

* Prevent accordion chevron from shrinking on smaller viewports

* fix: apply feedback
kjxbyz pushed a commit to muse-ui/muse-ui that referenced this pull request Jun 7, 2024
@FadyMak
fix(accordion): prevent accordion chevron from shrinking on smaller v…
2aa6803 
…iewports (shadcn-ui#717)

* Prevent accordion chevron from shrinking on smaller viewports

* fix: apply feedback
u007 pushed a commit to u007/ui that referenced this pull request Sep 1, 2024
@sinh117801
chore: update autoform emit submit event type(shadcn-ui#716) (shadcn-…
3dc6e10 
…ui#717)

If compiler options are only added to just tsconfig.json, module resolution fails for `@/lib/utils` during build.

<!---☝️ PR title should follow conventional commits (https://conventionalcommits.org) -->

<!-- Please ensure there is an open issue and mention its number as shadcn-ui#123 -->

<!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply. -->

- [ ] 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
- [ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
- [x] 👌 Enhancement (improving an existing functionality like performance)
- [ ] ✨ New feature (a non-breaking change that adds functionality)
- [ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
- [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

The change is mean to allow event type to support `values: z.infer<typeof schema>`, not only `values: Record<string, any>`

Resolves shadcn-ui#716

<!-- Add screenshots to help explain the change. -->

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->

- [x] I have linked an issue or discussion.
- [ ] I have updated the documentation accordingly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadcn shadcn shadcn approved these changes

@dan5py dan5py dan5py approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FadyMak @shadcn @dan5py