Skip to content

Commit

Permalink
chore: update autoform emit submit event type(shadcn-ui#716) (shadcn-…
Browse files Browse the repository at this point in the history
…ui#717)

If compiler options are only added to just tsconfig.json, module resolution fails for `@/lib/utils` during build.

<!---☝️ PR title should follow conventional commits (https://conventionalcommits.org) -->

<!-- Please ensure there is an open issue and mention its number as shadcn-ui#123 -->

<!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply. -->

- [ ] 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
- [ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
- [x] 👌 Enhancement (improving an existing functionality like performance)
- [ ] ✨ New feature (a non-breaking change that adds functionality)
- [ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
- [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

The change is mean to allow event type to support `values: z.infer<typeof schema>`, not only `values: Record<string, any>`

Resolves shadcn-ui#716

<!-- Add screenshots to help explain the change. -->

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->

- [x] I have linked an issue or discussion.
- [ ] I have updated the documentation accordingly.
  • Loading branch information
sinh117801 committed Aug 19, 2024
1 parent 12657da commit 3dc6e10
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const props = defineProps<{
}>()
const emits = defineEmits<{
submit: [event: GenericObject]
submit: [event: z.infer<T>]
}>()
const { dependencies } = toRefs(props)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const props = defineProps<{
}>()
const emits = defineEmits<{
submit: [event: GenericObject]
submit: [event: z.infer<T>]
}>()
const { dependencies } = toRefs(props)
Expand Down

0 comments on commit 3dc6e10

Please sign in to comment.