Updating tests in SAMRecordUnitTest to remove ambiguity #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rimitives * Tests were failing on debian systems due to ambiguity between boxed and unboxed number comparisons in SAMRecordUnitTest See #1695 * Fix the ambiguity by explictly converting values to the primitive types before comparing
|
@pgrt I've applied your patch. I'm not sure why it's necessary on your system and not on mine, but if it helps I'm happy to include it. Thanks for submitting! |
|
Hi, Thanks for taking it into account! In Debian we are getting ready for having openjdk-21 as the default jdk, perhaps the discussed error was triggered by the fact I built with this recent jdk. Have a great week, Pierre |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests were failing on Debian systems due to ambiguity between boxed and unboxed number comparisons in SAMRecordUnitTest See Ambiguous assertions in the tests #1695
Fix the ambiguity by explicitly converting values to the primitive types before comparing
Fixes Ambiguous assertions in the tests #1695