Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VCF 4.3 writing. #1596

Draft
wants to merge 24 commits into
base: master
Choose a base branch
from
Draft

VCF 4.3 writing. #1596

wants to merge 24 commits into from

Conversation

cmnbroad
Copy link
Collaborator

@cmnbroad cmnbroad commented Mar 1, 2022

Replacement for #1548. Depends on #1581, and will remain draft until #1581 is merged.

@cmnbroad cmnbroad force-pushed the cn_vcf43_writer branch 2 times, most recently from 62bc23f to 9a6e06b Compare March 1, 2022 14:51
@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2022

Codecov Report

Merging #1596 (f59a4e5) into master (347c0ac) will increase coverage by 0.086%.
The diff coverage is 78.414%.

❗ Current head f59a4e5 differs from pull request most recent head 0d625b7. Consider uploading reports for the commit 0d625b7 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@               Coverage Diff               @@
##              master     #1596       +/-   ##
===============================================
+ Coverage     69.856%   69.942%   +0.086%     
- Complexity      9695      9911      +216     
===============================================
  Files            703       708        +5     
  Lines          37772     38376      +604     
  Branches        6139      6249      +110     
===============================================
+ Hits           26386     26841      +455     
- Misses          8929      9046      +117     
- Partials        2457      2489       +32     
Impacted Files Coverage Δ
...in/java/htsjdk/samtools/SAMSequenceDictionary.java 75.000% <ø> (ø)
...dk/variant/variantcontext/VariantContextUtils.java 16.129% <ø> (ø)
...htsjdk/variant/vcf/VCFPassThruTextTransformer.java 50.000% <0.000%> (-50.000%) ⬇️
...c/main/java/htsjdk/variant/vcf/VCFRecordCodec.java 0.000% <0.000%> (ø)
src/main/java/htsjdk/variant/vcf/VCFCodec.java 21.429% <18.182%> (-55.844%) ⬇️
src/main/java/htsjdk/variant/vcf/VCFUtils.java 45.570% <28.571%> (-3.706%) ⬇️
...ta/codecs/variants/vcf/vcfv4_3/VCFDecoderV4_3.java 55.556% <33.333%> (-44.444%) ⬇️
src/main/java/htsjdk/variant/vcf/VCFEncoder.java 77.533% <43.750%> (-10.851%) ⬇️
src/main/java/htsjdk/variant/vcf/VCF3Codec.java 57.895% <50.000%> (-5.520%) ⬇️
...n/java/htsjdk/variant/vcf/VCFFormatHeaderLine.java 66.667% <57.895%> (-3.333%) ⬇️
... and 39 more

... and 30 files with indirect coverage changes

@cmnbroad cmnbroad mentioned this pull request Nov 7, 2023
5 tasks
@lbergelson lbergelson added VCFHeader Refactor Issues fixed by the header/line refactoring branch vcf labels Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vcf VCFHeader Refactor Issues fixed by the header/line refactoring branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants