-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating dependencies, SDKs, and more #368
Conversation
@mickael-menu @qnga Please review, especially the Kotlin file changes. I tested everything except for LCP. But please test with your devices too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @stevenzeck, I tested again the various formats with LCP too.
com.pspdfkit.R.id.pspdf__text_selection_toolbar_item_share, | ||
com.pspdfkit.R.id.pspdf__text_selection_toolbar_item_copy, | ||
com.pspdfkit.R.id.pspdf__text_selection_toolbar_item_speak |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this change have consequences? Maybe these resources cannot be overridden any more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually because android.nonTransitiveRClass defaults to true with the updated AGP version.
Another fix would be to set that to false in gradle.properties, then we can continue using R.id.something
instead of package.namespace.R.id.something
. There is only one other place this was necessary and it was in the testapp.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm that we can still override PSPDFKit strings with these changes, from an app's module. I tried with this:
<string name="pspdf__action_menu_copy">Test</string>
Looks to be an issue with ExoPlayer in which the test app requires |
@stevenzeck The ExoPlayer DownloadService is not used in the toolkit, so it should not be required. Did you encounter an issue with the Test App? |
So apparently we need this permission even without using the |
What's been updated
Important notes
kotlin-stdlib-jdk7
or 8 as they have been merged into a straightforwardkotlin-stdlib
. https://kotlinlang.org/docs/whatsnew18.html#updated-jvm-compilation-target.R.id.search_close_btn
is nowandroidx.appcompat.R.id.search_close_btn
.BuildConfig
is needed for individual modules,buildConfig = true
must be added to thebuildFeatures
block in build.gradle.kts for that module.What else changed
android.permission.FOREGROUND_SERVICE_MEDIA_PLAYBACK
in order for TTS or Audiobook playback to work.