Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various changes for v3 #367

Merged
merged 17 commits into from
Jul 26, 2023
Merged

Various changes for v3 #367

merged 17 commits into from
Jul 26, 2023

Conversation

mickael-menu
Copy link
Member

@mickael-menu mickael-menu commented Jul 21, 2023 •
edited
Loading

  • Remove unused resources.
  • Set all @Deprecated annotations to ERROR level.
  • Make a lot of EPUB components internal.
  • Require explicit API in all the modules.
    • Note that until Kotlin 1.9 (upgraded in this PR) this won't be checked properly, unless we use -Xexplicit-api=strict. I didn't because it would apply to the test modules as well, which is not desirable.

@mickael-menu mickael-menu requested a review from qnga July 21, 2023 16:34
@mickael-menu mickael-menu marked this pull request as draft July 22, 2023 08:46
@mickael-menu mickael-menu marked this pull request as ready for review July 24, 2023 14:38
qnga
qnga reviewed Jul 25, 2023
View reviewed changes
Copy link
Contributor

@qnga qnga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great clean up!

readium/lcp/src/main/java/org/readium/r2/lcp/LcpDecryptorTest.kt Outdated Show resolved Hide resolved
readium/navigator/src/main/java/org/readium/r2/navigator/extensions/Locator.kt Outdated Show resolved Hide resolved
readium/navigator/src/main/java/org/readium/r2/navigator/pager/R2RTLViewPager.java Show resolved Hide resolved
readium/shared/src/main/java/org/readium/r2/shared/fetcher/Resource.kt Outdated Show resolved Hide resolved
readium/shared/src/main/java/org/readium/r2/shared/fetcher/Resource.kt Show resolved Hide resolved
readium/shared/src/main/java/org/readium/r2/shared/parser/xml/XmlParser.kt Show resolved Hide resolved
readium/shared/src/main/java/org/readium/r2/shared/publication/Publication.kt Show resolved Hide resolved
readium/shared/src/main/java/org/readium/r2/shared/publication/ReadingProgression.kt Show resolved Hide resolved
readium/shared/src/main/java/org/readium/r2/shared/util/URITemplate.kt Show resolved Hide resolved
@mickael-menu mickael-menu requested a review from qnga July 25, 2023 15:29
@qnga qnga merged commit 00039b9 into v3 Jul 26, 2023
3 checks passed
@qnga qnga deleted the fix-v3 branch July 26, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qnga qnga qnga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mickael-menu @qnga