Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish SQL functions refactoring #543

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

dreadatour
Copy link
Contributor

@dreadatour dreadatour commented Oct 28, 2024

WIP: need to cleanup the code and fix all the tests. Description will be updated.

@dreadatour dreadatour self-assigned this Oct 28, 2024
@dreadatour dreadatour marked this pull request as draft October 28, 2024 12:44
Copy link

cloudflare-workers-and-pages bot commented Oct 28, 2024

Deploying datachain-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: 26fb69c
Status: ✅  Deploy successful!
Preview URL: https://5f4ad33a.datachain-documentation.pages.dev
Branch Preview URL: https://525-sql-functions.datachain-documentation.pages.dev

View logs

@dreadatour dreadatour linked an issue Oct 28, 2024 that may be closed by this pull request
@dreadatour dreadatour force-pushed the 525-sql-functions branch 4 times, most recently from 04c16a5 to 00cdb0d Compare October 29, 2024 01:58
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 80.05952% with 67 lines in your changes missing coverage. Please review.

Project coverage is 87.05%. Comparing base (529c297) to head (26fb69c).

Files with missing lines Patch % Lines
src/datachain/lib/func/func.py 64.03% 35 Missing and 6 partials ⚠️
src/datachain/lib/func/string.py 74.28% 6 Missing and 3 partials ⚠️
src/datachain/lib/dc.py 78.94% 4 Missing and 4 partials ⚠️
src/datachain/lib/func/array.py 85.00% 6 Missing ⚠️
src/datachain/cli.py 0.00% 1 Missing ⚠️
src/datachain/client/fsspec.py 83.33% 0 Missing and 1 partial ⚠️
src/datachain/lib/func/inner/base.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #543      +/-   ##
==========================================
- Coverage   87.37%   87.05%   -0.33%     
==========================================
  Files          97      102       +5     
  Lines       10178    10410     +232     
  Branches     1391     1437      +46     
==========================================
+ Hits         8893     9062     +169     
- Misses        922      974      +52     
- Partials      363      374      +11     
Flag Coverage Δ
datachain 86.99% <80.05%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dreadatour dreadatour force-pushed the 525-sql-functions branch 5 times, most recently from cb93180 to 83cbb49 Compare October 29, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finish SQL functions refactoring
1 participant