Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish SQL functions refactoring #525

Open
dreadatour opened this issue Oct 21, 2024 · 1 comment · May be fixed by #543
Open

Finish SQL functions refactoring #525

dreadatour opened this issue Oct 21, 2024 · 1 comment · May be fixed by #543
Assignees
Labels
enhancement New feature or request

Comments

@dreadatour
Copy link
Contributor

dreadatour commented Oct 21, 2024

This is a follow-up issue for the #228 and #227.

We now have SQL functions implemented in two places:

We need to update the code to use new func module only.

@dmpetrov:

Yes, it should be imported from top level: from datachain.func import min, concat

@dreadatour dreadatour added the enhancement New feature or request label Oct 21, 2024
@dmpetrov
Copy link
Member

dmpetrov commented Oct 21, 2024

another requirement: we should never expose keywords like sql and sqlalchemy. it introduces quite a bit of confusion.

Users should be able implementing theirs scenario without touching these keywords and libs.

@dreadatour dreadatour linked a pull request Oct 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants