handle nan and inf float values #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying datachain-documentation with
|
| Latest commit: |
f909bc7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c4808f6d.datachain-documentation.pages.dev |
| Branch Preview URL: | https://nan-inf.datachain-documentation.pages.dev |
added 2 commits
August 7, 2024 14:41
dberenbaum
commented
Aug 7, 2024
Comment on lines
+1418
to
+1420
| convert_options = ConvertOptions( | ||
| strings_can_be_null=True, null_values=STR_NA_VALUES | ||
| ) |
There was a problem hiding this comment.
This provides pandas-like null handling for csv files
dberenbaum
commented
Aug 7, 2024
| @@ -45,12 +47,12 @@ class TeamMember(BaseModel): | |||
|
|
|||
|
|
|||
| def test_merge_objects(test_session): | |||
| skip_if_not_sqlite() | |||
There was a problem hiding this comment.
See the note about joins in https://github.com/iterative/studio/pull/10429
dberenbaum
commented
Aug 7, 2024
| @@ -103,14 +105,13 @@ def test_merge_similar_objects(test_session): | |||
|
|
|||
|
|
|||
| def test_merge_values(test_session): | |||
| skip_if_not_sqlite() | |||
There was a problem hiding this comment.
See the note about joins in https://github.com/iterative/studio/pull/10429
|
Remaining test failures are either unrelated or require https://github.com/iterative/studio/pull/10429 |
dmpetrov
approved these changes
Aug 7, 2024
|
|
||
|
|
||
| def test_from_values_nan_inf(tmp_dir, catalog): | ||
| vals = [float("nan"), float("inf"), float("-inf")] |
|
Going to merge but we should follow up on arrays and CH joins |
mattseddon
added a commit
that referenced
this pull request
Aug 13, 2024
This reverts commit 8e0f970.
@dberenbaum can we please review and create a ticket in the DataChain repo for this if needed? |
Opened #386. CH was fixed by https://github.com/iterative/studio/pull/10471. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for https://github.com/iterative/dvcx/issues/1697#issuecomment-2269457257:
Array(Float)support that - needs follow-up since orjson does not support nan/infThis PR treats all missing values in float columns as NaN for a couple reasons: