Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove erroneous skip_if_not_sqlite calls #302

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Aug 14, 2024

Goes on top of #296

Leftover from #254 and #249 being merged at roughly the same time

Copy link

cloudflare-workers-and-pages bot commented Aug 14, 2024

Deploying datachain-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: 56960ae
Status: ✅  Deploy successful!
Preview URL: https://64fea537.datachain-documentation.pages.dev
Branch Preview URL: https://remove-redundant-call.datachain-documentation.pages.dev

View logs

@mattseddon mattseddon marked this pull request as ready for review August 14, 2024 21:52
@mattseddon mattseddon self-assigned this Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.91%. Comparing base (bbcff85) to head (56960ae).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #302   +/-   ##
=======================================
  Coverage   86.91%   86.91%           
=======================================
  Files          89       89           
  Lines        9768     9768           
  Branches     1981     1981           
=======================================
  Hits         8490     8490           
  Misses        935      935           
  Partials      343      343           
Flag Coverage Δ
datachain 86.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from float-nan-fix to main August 15, 2024 13:46
Copy link
Contributor

@dreadatour dreadatour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! ❤️

@mattseddon mattseddon merged commit ea02700 into main Aug 15, 2024
38 checks passed
@mattseddon mattseddon deleted the remove-redundant-call branch August 15, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants