Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump axe-core from 4.9.1 to 4.10.1 #6620

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 21, 2024

Bumps axe-core from 4.9.1 to 4.10.1.

Release notes

Sourced from axe-core's releases.

Release 4.10.1

Because a few false positives were fixed, this release may see the number of reported issues go down. In pages with lots of very similar elements a performance bottleneck was fixed, allowing axe to finish sometimes up to 10x faster, although for most pages there won't be a difference. Lastly there is a small change to the ancestry selector of elements in shadow DOM. These weren't always guaranteed to be unique. The change means deduplication based on ancestry selectors may not work between 4.10.1 and older versions.

Bug Fixes

Release 4.10.0

This axe-core release introduces a new rule for testing the HTML summary element. Additionally, a number of false positives have been fixed. Upgrading to this release may therefore both increase, or decrease the number of issues found on a website. Most likely the impact of upgrading from axe-core 4.9.2 to axe-core 4.10.0 should be minimal.

Features

  • new-rule: summary elements must have an accessible name (#4511) (0d8a99e), closes #4510

Bug Fixes

  • aria-allowed-attr: allow aria-multiline=false for element with contenteditable (#4537) (f019068)
  • aria-allowed-attr: allow aria-required=false when normally not allowed (#4532) (2e242e1)
  • aria-prohibited-attr: allow aria-label/ledby on descendants of widget (#4541) (07c5d91)
  • aria-roledescription: keep disabled with { runOnly: 'wcag2a' } (#4526) (5b4cb9d), closes #4523
  • autocomplete-valid: incomplete for invalid but safe values (#4500) (e31a974), closes #4492
  • build: limit locales to valid files when using the --all-lang option (#4486) (d3db593), closes #4485
  • Prevent errors when loading axe in Angular + Jest (#4456) (3ef9353), closes #4400
  • Minor grammatical fixes for some rules and checks (#4499) (11fad59)
  • landmark-unique: follow spec, aside -> landmark (#4469) (e32f803), closes #4460
  • required-attr: allow aria-valuetext on slider instead of valuenow (#4518) (135898b), closes #4515
Changelog

Sourced from axe-core's changelog.

4.10.1 (2024-10-16)

Bug Fixes

4.10.0 (2024-07-29)

Features

  • new-rule: summary elements must have an accessible name (#4511) (0d8a99e), closes #4510

Bug Fixes

  • aria-allowed-attr: allow aria-multiline=false for element with contenteditable (#4537) (f019068)
  • aria-allowed-attr: allow aria-required=false when normally not allowed (#4532) (2e242e1)
  • aria-prohibited-attr: allow aria-label/ledby on descendants of widget (#4541) (07c5d91)
  • aria-roledescription: keep disabled with { runOnly: 'wcag2a' } (#4526) (5b4cb9d), closes #4523
  • autocomplete-valid: incomplete for invalid but safe values (#4500) (e31a974), closes #4492
  • build: limit locales to valid files when using the --all-lang option (#4486) (d3db593), closes #4485
  • Prevent errors when loading axe in Angular + Jest (#4456) (3ef9353), closes #4400
  • Minor grammatical fixes for some rules and checks (#4499) (11fad59)
  • landmark-unique: follow spec, aside -> landmark (#4469) (e32f803), closes #4460
  • required-attr: allow aria-valuetext on slider instead of valuenow (#4518) (135898b), closes #4515
Commits
  • b581695 chore(release): v4.10.1 (#4615)
  • 316b54c chore(release): 4.10.1
  • 365acae perf(selector): more caching for faster selector creation (#4611)
  • ae3d6db docs(readme): link download badge to npm-stats.com (#4603)
  • bdd94a2 fix(get-ancestry): add nth-child selector for multiple siblings of shadow roo...
  • 364eb72 fix(button-name,input-button-name,input-img-alt): allow label to give accessi...
  • a95ed13 test: fix flakiness in rerun integration test (#4598)
  • e66c368 chore: avoid auto-formatter workflow failing on fork PRs (#4600)
  • c404266 chore: sync generated files (#4597)
  • 31e0f61 fix(rules): Change "alternate text" to "alternative text" (#4582)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Oct 21, 2024
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/axe-core-4.10.1 branch from d5f7cd1 to 8554b46 Compare October 21, 2024 14:44
Bumps [axe-core](https://github.com/dequelabs/axe-core) from 4.9.1 to 4.10.1.
- [Release notes](https://github.com/dequelabs/axe-core/releases)
- [Changelog](https://github.com/dequelabs/axe-core/blob/develop/CHANGELOG.md)
- [Commits](dequelabs/axe-core@v4.9.1...v4.10.1)

---
updated-dependencies:
- dependency-name: axe-core
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@robertknight
Copy link
Member

robertknight commented Oct 22, 2024

The ExportAnnotations component test is reporting a button-name exception for the file type dropdown field. According to Chrome's accessibility inspector, this button has a value but not a name:

button-name-warning

The existing tests do have a violation suppression for the user-dropdown field, but that violation is no longer triggered.

The space for the export format select is limited so we rely on a combination of
the value and the descriptions in the dropdown content to indicate what it is
for. axe-core doesn't understand this though, so add an accessible label as
well.

In the process remove an accessibility violation suppression for the user
dropdown, as that violation is no longer reported.
@robertknight
Copy link
Member

The issue has now been fixed by:

  • Removing the obsolete suppression for the user dropdown field
  • Adding an accessible label for the export format field

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.42%. Comparing base (19b4399) to head (2cb18a4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6620   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files         270      270           
  Lines       10175    10175           
  Branches     2419     2419           
=======================================
  Hits        10117    10117           
  Misses         58       58           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robertknight robertknight merged commit dec4f24 into main Oct 22, 2024
4 checks passed
@robertknight robertknight deleted the dependabot/npm_and_yarn/axe-core-4.10.1 branch October 22, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants