You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When debugging a test failure with an axe-core update in hypothesis/client#6620 I ran into a confusing issue where elements were missing from the Enzyme wrapper in the shouldIgnoreViolations callback to checkAccessibility. The reason is that the component gets unmounted before violations are filtered with shouldIgnoreViolations. See
Querying the Enzyme tree inside this callback is probably going to be a common need, so we should probably defer unmounting until after it has been used.
The text was updated successfully, but these errors were encountered:
Change a potentially confusing behavior where components were unmounted before
calling the `shouldIgnoreViolation` callback. Querying the rendered tree within
the callback, eg. to get the ID of an element to check if a violation relates to
it, could fail due to this.
Fixes#48.
When debugging a test failure with an axe-core update in hypothesis/client#6620 I ran into a confusing issue where elements were missing from the Enzyme wrapper in the
shouldIgnoreViolations
callback tocheckAccessibility
. The reason is that the component gets unmounted before violations are filtered withshouldIgnoreViolations
. Seefrontend-testing/src/accessibility.ts
Line 55 in a076a7e
Querying the Enzyme tree inside this callback is probably going to be a common need, so we should probably defer unmounting until after it has been used.
The text was updated successfully, but these errors were encountered: