Wrapper is unmounted when shouldIgnoreViolations is called
#48
Comments
robertknight
added a commit
that referenced
this issue
Oct 22, 2024
Change a potentially confusing behavior where components were unmounted before calling the `shouldIgnoreViolation` callback. Querying the rendered tree within the callback, eg. to get the ID of an element to check if a violation relates to it, could fail due to this. Fixes #48.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When debugging a test failure with an axe-core update in hypothesis/client#6620 I ran into a confusing issue where elements were missing from the Enzyme wrapper in the
shouldIgnoreViolationscallback tocheckAccessibility. The reason is that the component gets unmounted before violations are filtered withshouldIgnoreViolations. Seefrontend-testing/src/accessibility.ts
Line 55 in a076a7e
Querying the Enzyme tree inside this callback is probably going to be a common need, so we should probably defer unmounting until after it has been used.
The text was updated successfully, but these errors were encountered: