Refactor dropdown comments handling #17981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
3 tasks
cedric-anne
force-pushed
the
11.0/dropdown-comments
branch
3 times, most recently
from
3d1a847
to
496e609
Compare
cedric-anne
force-pushed
the
11.0/dropdown-comments
branch
from
496e609
to
e6c647f
Compare
|
HTML generation should be done from Twig, I do not really understand why keeping that PHP side finally. |
Just because I did not take time to do it, but indeed, it is better to do it using a Twig template. |
AdrienClairembault
approved these changes
Oct 31, 2024
trasher
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Description
I extracted the
commentscomputation from theDropdown::getDropdownName()method and move it into aDropdown::getDropdownComments()in order to not have a mix between raw data and HTML encoded data in the same method result.Dropdown::getDropdownName()will now always return a raw value.Dropdown::getDropdownComments()will always return a safe HTML string.