Remove extra HTML encoding

[cedric-anne]

Checklist before requesting a review

• I have read the CONTRIBUTING document.
• I have performed a self-review of my code.

Description

Follows #17927 and #17928

Commit 1: The /front/cron.php script is often use in CLI context. The HTML special chars should not be encoded in this case. I also encapsulate the strings in the __() function to make them translatable.

Commit 2: comments returned by Dropdown::getDropdownName() contains legitimate HTML, it should not be re-encoded.

[trasher]

Since the cron script is not really made to be called with a specific language (and anyway it can be a different language than the one who will receive cron message) - I'm not sure making strings translatable is really a good idea.
Also, it requires extra work from translators.

[trasher]

Commit 2: comments returned by Dropdown::getDropdownName() contains legitimate HTML, it should not be re-encoded.

Well... That's a hard case to handle; because it can always contain HTML we have to escape (and a get method should not do that). Seems wrong not to escape, and seems wrong to escape.... I've thrown a LogicalException :D

[cedric-anne]

Since the cron script is not really made to be called with a specific language (and anyway it can be a different language than the one who will receive cron message) - I'm not sure making strings translatable is really a good idea. Also, it requires extra work from translators.

We could remove translations, and then we would be sure that we have nothing to encode, as the strings does not contain >, < or &.

[cedric-anne]

Commit 2: comments returned by Dropdown::getDropdownName() contains legitimate HTML, it should not be re-encoded.

Well... That's a hard case to handle; because it can always contain HTML we have to escape (and a get method should not do that). Seems wrong not to escape, and seems wrong to escape.... I've thrown a LogicalException :D

This method should be splitted, as I have done for the getUserName() function in #17872, to have a method that returns the raw (non encoded) name, and a method that returns the "tooltip HTML code" where variables are correctly encoded.

I will try to implement this solution.

[cedric-anne]

See #17981 and #17982 .