Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra] Upgrade dependencies that cause warnings when installing with React 18 #7214

Merged
merged 4 commits into from
Sep 26, 2023

Conversation

cee-chen
Copy link
Member

@cee-chen cee-chen commented Sep 21, 2023

Summary

closes #7080

QA

  • yarn build-pack, then move to the .tgz file to somewhere you can easily point to
  • npx create-react-app test-eui-18-app && cd test-eui-18-app
  • Install peer dependencies:
yarn add @elastic/datemath @emotion/react @emotion/css moment prop-types [email protected] @types/react @types/react-dom
  • Open package.json and add @elastic/eui pointed at the local tgz file, e.g. "@elastic/eui": "/Users/YOURNAME/Documents/elastic-eui-88.4.1.tgz",
  • Open src/App.js and import and render an EuiButton
  • yarn
  • Confirm no warning @elastic/eui messages while installing EUI (CRA has a few of its own, but shouldn't be related to EUI)
  • yarn start
  • Confirm EuiButton renders as expected

General checklist

  • Release checklist
    • A changelog entry exists and is marked appropriately.

`vfile` dependency already has types at currently installed version
@cee-chen cee-chen marked this pull request as ready for review September 26, 2023 15:31
@cee-chen cee-chen requested a review from a team as a code owner September 26, 2023 15:31
@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

Copy link
Contributor

@1Copenut 1Copenut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM! I ran through the manual QA with no issues.

@cee-chen
Copy link
Member Author

Thanks a million Trevor!

@cee-chen cee-chen merged commit e901c63 into elastic:main Sep 26, 2023
8 checks passed
@cee-chen cee-chen deleted the react-18-deps branch September 26, 2023 22:53
cee-chen added a commit to elastic/kibana that referenced this pull request Oct 4, 2023
`v88.5.0`⏩`v88.5.4`

This EUI upgrade helps unblock the Shared UX team with some beta
serverless nav updates not listed in the below changelog
(elastic/eui#7228 and
elastic/eui#7248).

---

## [`88.5.4`](https://github.com/elastic/eui/tree/v88.5.4)

- This release contains internal changes to a beta component needed by
Kibana.

## [`88.5.3`](https://github.com/elastic/eui/tree/v88.5.3)

**Bug fixes**

- Fixed `EuiComboBox` search input width not resetting correctly on
selection ([#7240](elastic/eui#7240))

## [`88.5.2`](https://github.com/elastic/eui/tree/v88.5.2)

**Bug fixes**

- Fixed broken `EuiTextTruncate` testenv mocks
([#7234](elastic/eui#7234))

## [`88.5.1`](https://github.com/elastic/eui/tree/v88.5.1)

- Improved the performance of `EuiComboBox` by removing the
`react-autosizer-input` dependency
([#7215](elastic/eui#7215))

**Dependency updates**

- Updated `react-element-to-jsx-string` to v5.0.0
([#7214](elastic/eui#7214))
- Removed unused `@types/vfile-message` dependency
([#7214](elastic/eui#7214))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation warnings when using React 18 (react-input-autosize react-element-to-jsx-string)
4 participants