Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation warnings when using React 18 (react-input-autosize react-element-to-jsx-string) #7080

Closed
j-m opened this issue Aug 14, 2023 · 1 comment · Fixed by #7214
Closed
Assignees
Labels
bug ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible

Comments

@j-m
Copy link
Contributor

j-m commented Aug 14, 2023

Hey folks! Thanks for adding support for React 17 and 18, it's much appreciated!

However, there are a couple of warnings when installing eui with react 18:

npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: [email protected]
npm WARN Found: [email protected]
npm WARN node_modules/react
npm WARN peer react@"^16.12 || ^17.0 || ^18.0" from @elastic/[email protected]
npm WARN node_modules/@elastic/eui
npm WARN peer @elastic/eui@"^87.0.0" from the root project
npm WARN 83 more (@emotion/react, ...)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer react@"^0.14.8 || ^15.0.1 || ^16.0.0 || ^17.0.1" from [email protected]
npm WARN node_modules/@elastic/eui/node_modules/react-element-to-jsx-string
npm WARN react-element-to-jsx-string@"^14.3.4" from @elastic/[email protected]
npm WARN node_modules/@elastic/eui
npm WARN
npm WARN Conflicting peer dependency: [email protected]
npm WARN node_modules/react
npm WARN peer react@"^0.14.8 || ^15.0.1 || ^16.0.0 || ^17.0.1" from [email protected]
npm WARN node_modules/@elastic/eui/node_modules/react-element-to-jsx-string
npm WARN react-element-to-jsx-string@"^14.3.4" from @elastic/[email protected]
npm WARN node_modules/@elastic/eui
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: [email protected]
npm WARN Found: [email protected]
npm WARN node_modules/react-dom
npm WARN peer react-dom@"^16.12 || ^17.0 || ^18.0" from @elastic/[email protected]
npm WARN node_modules/@elastic/eui
npm WARN peer @elastic/eui@"^87.0.0" from the root project
npm WARN 49 more (@floating-ui/react-dom, @hello-pangea/dnd, ...)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer react-dom@"^0.14.8 || ^15.0.1 || ^16.0.0 || ^17.0.1" from [email protected]
npm WARN node_modules/@elastic/eui/node_modules/react-element-to-jsx-string
npm WARN react-element-to-jsx-string@"^14.3.4" from @elastic/[email protected]
npm WARN node_modules/@elastic/eui
npm WARN
npm WARN Conflicting peer dependency: [email protected]
npm WARN node_modules/react-dom
npm WARN peer react-dom@"^0.14.8 || ^15.0.1 || ^16.0.0 || ^17.0.1" from [email protected]
npm WARN node_modules/@elastic/eui/node_modules/react-element-to-jsx-string
npm WARN react-element-to-jsx-string@"^14.3.4" from @elastic/[email protected]
npm WARN node_modules/@elastic/eui
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: [email protected]
npm WARN Found: [email protected]
npm WARN node_modules/react
npm WARN peer react@"^16.12 || ^17.0 || ^18.0" from @elastic/[email protected]
npm WARN node_modules/@elastic/eui
npm WARN peer @elastic/eui@"^87.0.0" from the root project
npm WARN 83 more (@emotion/react, ...)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer react@"^16.3.0 || ^17.0.0" from [email protected]
npm WARN node_modules/@elastic/eui/node_modules/react-input-autosize
npm WARN react-input-autosize@"^3.0.0" from @elastic/[email protected]
npm WARN node_modules/@elastic/eui
npm WARN
npm WARN Conflicting peer dependency: [email protected]
npm WARN node_modules/react
npm WARN peer react@"^16.3.0 || ^17.0.0" from [email protected]
npm WARN node_modules/@elastic/eui/node_modules/react-input-autosize
npm WARN react-input-autosize@"^3.0.0" from @elastic/[email protected]
npm WARN node_modules/@elastic/eui

Which is a really long way of saying react-input-autosize only supports peer react@"^16.3.0 || ^17.0.0" and
react-element-to-jsx-string only supports peer react-dom@"^0.14.8 || ^15.0.1 || ^16.0.0 || ^17.0.1".

Which appears to be right, react-input-autosize doesn't support it at all (there's a fork tho):
JedWatson/react-input-autosize#196
and you need react-element-to-jsx-string to be on v15

@j-m j-m added bug ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible labels Aug 14, 2023
@breehall breehall assigned cee-chen and unassigned tkajtoch Sep 19, 2023
@cee-chen
Copy link
Member

cee-chen commented Sep 21, 2023

Sorry it took us a while to get to this @j-m (and thanks as always for the incredibly helpful issue descriptions!) This should be fixed shortly by #7214 / in the next EUI release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants