Onboarding Add to Dock Promo view #3505
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1206329551987282/1208577512136709
Description:
Add the Add to Dock Promo view to the final dialog of the onboarding flow.
Steps to test this PR:
Add
return VariantIOS(name: "mx", weight: 1, isIncluded: VariantIOS.When.always, features: [.newOnboardingIntroHighlights, .contextualDaxDialogs])inDefaultVariantManager->selectVariant()at line 156.Ensure that
OnboardingManager->isAddToDockEnabledreturns true.Launch the App and start the onboarding flow.
Select and icon color different from the default one.
Complete the contextual onboarding flow.
Ensure the Add To Dock promo view is shown in the final dialog of the onboarding flow and app icon in the animation reflects the color of the icon selected during the onboarding.
Tap "Show Me How” and ensure the tutorial video about how to add the icon to the dock is shown and loops.
Repeat the test selecting the default icon color.
Repeat the test and show the end of journey dialog from contextual dialog instead from new tab page.
Definition of Done (Internal Only):
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template