Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to Dock - Add extra custom view to Contextual Dialog Content #1043

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alessandroboron
Copy link
Contributor

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/1206329551987282/1208577512136709
iOS PR: duckduckgo/iOS#3505
macOS PR: duckduckgo/macos-browser#3479
What kind of version bump will this require?: Major

Description:

Add the Add to Dock Promo view to the final dialog of the onboarding flow.

Steps to test this PR:

  1. Ensure BSK "Intro Dialog - title, text, image and button" Preview works as expected
  2. For macOS see macOS PR.
  3. For iOS see iOS PR.

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
  • macOS 10.15
  • macOS 11
  • macOS 12

Internal references:

Software Engineering Expectations
Technical Design Template

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant