Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SubscriptionsManager refactoring #5205

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

SubscriptionsManager refactoring #5205

wants to merge 15 commits into from

Commits on Oct 28, 2024

  1. move logic out of auth repository

    @lmac012
    lmac012 committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    38b3563 View commit details
    Browse the repository at this point in the history

  2. rename method for consistency

    @lmac012
    lmac012 committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    675ed70 View commit details
    Browse the repository at this point in the history

  3. remove unused method

    @lmac012
    lmac012 committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    031fc82 View commit details
    Browse the repository at this point in the history

  4. simplify AuthRepository interface

    @lmac012
    lmac012 committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    261eaa1 View commit details
    Browse the repository at this point in the history

  5. move account deletion logic to internal module

    @lmac012
    lmac012 committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    a13e4f7 View commit details
    Browse the repository at this point in the history

  6. decouple Entitlements from Subscription in AuthRepository API

    @lmac012
    lmac012 committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    3be6fd7 View commit details
    Browse the repository at this point in the history

  7. ignore entitlements for inactive subs, but don't remove them

    @lmac012
    lmac012 committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    291df1d View commit details
    Browse the repository at this point in the history

  8. move ignoring entilements for inactive subscription down one layer

    @lmac012
    lmac012 committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    9942727 View commit details
    Browse the repository at this point in the history

  9. emit empty entitlements after signing out

    @lmac012
    lmac012 committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    e2c4382 View commit details
    Browse the repository at this point in the history

  10. remove redundant suspend modifiers

    @lmac012
    lmac012 committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    fc5b018 View commit details
    Browse the repository at this point in the history

  11. don't return Subscription from fetchAndStoreAllData()

    @lmac012
    lmac012 committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    b9b33df View commit details
    Browse the repository at this point in the history

  12. rename AuthToken and AccessToken to AuthTokenResult and AccessTokenRe… 

    …sult respectively
    @lmac012
    lmac012 committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    d759817 View commit details
    Browse the repository at this point in the history

  13. move adding authorization header to an interceptor

    @lmac012
    lmac012 committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    00e8ddb View commit details
    Browse the repository at this point in the history

  14. fix outdated kdoc

    @lmac012
    lmac012 committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    6a24c20 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. rename method to make it consistent with the corresponding isSignedIn… 

    … property
    @lmac012
    lmac012 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    118a9e5 View commit details
    Browse the repository at this point in the history