Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SubscriptionsManager refactoring #5205

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

lmac012
Copy link
Contributor

@lmac012 lmac012 commented Oct 28, 2024

Task/Issue URL: https://app.asana.com/0/1205648422731273/1208643784411875/f

Description

Steps to test this PR

Smoke test Privacy Pro (no behavior changes are expected)

  • Purchase test subscription
  • Remove from device
  • Restore using Play
  • Cancel subscription
  • Wait for it to expire
  • Purchase again

No UI changes

@lmac012
Copy link
Contributor Author

lmac012 commented Oct 28, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @lmac012 and the rest of your teammates on Graphite Graphite

@lmac012 lmac012 marked this pull request as ready for review October 28, 2024 22:31
Copy link
Contributor

@karlenDimla karlenDimla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected. Also synced with Lukazs with some of the changes to get a better understanding of the motivation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants