generated from canonical/is-charms-template-repo
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support builds-on/runs-on arm #94
Open
addyess
wants to merge
14
commits into
main
Choose a base branch
from
akd/support-arm64-builds
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+113
−89
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
eedbd9f
Support builds-on/runs-on arm
addyess f7570bb
Build ARM64 and AMD64 charms
addyess bb17644
Make use of self-hosted runners
addyess 57c6cea
Use runner arch in build cache
addyess 3198495
Run charmcraft with lxd permissions
addyess 03bb3bc
attempt to use better-build workflows
addyess 14992e0
Use arch specific better builder
addyess a23d0df
Switch back to using main branch of operator-workflows
addyess e96e922
re-enable arm64 builds
addyess 4641fe7
Set arch constraint on every application in a bundle
addyess 4c42ca4
Update the charm contribution guide
addyess aa3d6f8
Appropriately add arch to constraints
addyess 7ffcab0
Adapt to latest workflow merge
addyess c4f6647
add arch constraint to each application
addyess File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,6 +43,20 @@ bases: | |
- name: ubuntu | ||
channel: "24.04" | ||
architectures: [amd64] | ||
- build-on: | ||
- name: ubuntu | ||
channel: "20.04" | ||
architectures: [arm64] | ||
run-on: | ||
- name: ubuntu | ||
channel: "20.04" | ||
architectures: [arm64] | ||
- name: ubuntu | ||
channel: "22.04" | ||
architectures: [arm64] | ||
- name: ubuntu | ||
channel: "24.04" | ||
architectures: [arm64] | ||
config: | ||
options: | ||
labels: | ||
|
@@ -59,6 +73,7 @@ parts: | |
plugin: charm | ||
build-packages: [git] | ||
charm-entrypoint: k8s/src/charm.py | ||
charm-requirements: [k8s/requirements.txt] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. worker charm can specify it's |
||
promote: | ||
# move paths out of ./k8s to ./ since | ||
# charmcraft assumes ./lib to be there | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some study on a failure on ARM now that we're testing with lxd VMs.
lxd is required to use
/dev/kvm
, but on ARM64 --/dev/kvm
may not exist. I even logged into the machine and tried to addsudo modprobe kvm
but it fails to load the kernel mode.without
/dev/kvm
-- lxd doesn't start the machines and the tests failTherefore -- this change allows for lxd-containers on ARM -- but i expect we'd need arm64 to support
/dev/kvm
or don't use lxd as a cloud for arm64