-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support builds-on/runs-on arm #94
base: main
Are you sure you want to change the base?
Conversation
@@ -58,6 +72,7 @@ parts: | |||
charm: | |||
build-packages: [git] | |||
charm-entrypoint: k8s/src/charm.py | |||
charm-requirements: [k8s/requirements.txt] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
worker charm can specify it's requirements.txt
so that the python reqs can be installed with no-binary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6c4b410
to
fc4546b
Compare
fea3024
to
d472d1e
Compare
145ff2b
to
a3ed49c
Compare
NOW this PR depends on merging of this PR in order to get multiarch builds back |
a3ed49c
to
18db955
Compare
thanks to @arturo-seijas and @weiiwang01 for unblocking this |
2b46127
to
56caa0d
Compare
ababe73
to
3a3b717
Compare
81f9f5d
to
7627060
Compare
d2bcb9a
to
858254a
Compare
858254a
to
c4f6647
Compare
Test coverage for c4f6647
Static code analysis report
|
extra-arguments: >- | ||
${{needs.extra-args.outputs.args}} -k test_${{ matrix.suite }} | ||
${{ matrix.arch.id == 'arm64' && ' --lxd-containers' || '' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some study on a failure on ARM now that we're testing with lxd VMs.
lxd is required to use /dev/kvm
, but on ARM64 -- /dev/kvm
may not exist. I even logged into the machine and tried to add sudo modprobe kvm
but it fails to load the kernel mode.
without /dev/kvm
-- lxd doesn't start the machines and the tests fail
Therefore -- this change allows for lxd-containers on ARM -- but i expect we'd need arm64 to support /dev/kvm
or don't use lxd as a cloud for arm64
Adding a builds-on/runs-on arm64 section for each charm