Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Cooler 'Retain Rendering World' #15320

Open
wants to merge 70 commits into
base: main
Choose a base branch
from
Open

The Cooler 'Retain Rendering World' #15320

wants to merge 70 commits into from
+729 −271

Conversation

Trashtalk217
Copy link
Contributor

re0312 and others added 30 commits July 7, 2024 05:55
@re0312
init
95b7f0b
@re0312
sync
17f2bb0
@re0312
cleanup
35fe01e
@re0312
clean
f9bae87
@re0312
fix
34853b2
@re0312
Fly
000cef4
@re0312
Merge branch 'main' into retain_world
2255b21
@re0312
fly entity
f90c360
@re0312
sync world
756b082
@re0312
ui
5b5ef76
@re0312
lighting
e15e3a3
@re0312
fix example
e4e0bc0
@re0312
ui
33cae8d
@re0312
fix ui
4a58b0e
@re0312
fix gizmos
3fc2207
@re0312
fix light
f9c8d5a
@re0312
cleanup
44d36a4
@re0312
Merge branch 'main' into retain_world
9a7d641
@re0312
fix cli
7989d21
@re0312
fix ui
9485455
@re0312
clean
bb3289b
@re0312
fix cli
39e4f2e
@re0312
fix ui_material
4b6506e
@re0312
fix sprite
03a6e09
@re0312
whilelist
b8b8225
@re0312
Revert "whilelist"
24212f5 
This reverts commit b8b8225.
@re0312
address review
2de636a
@re0312 @Trashtalk217
Update crates/bevy_render/src/world_sync.rs
1fbb76c 
Co-authored-by: Trashtalk217 <[email protected]>
@re0312 @Trashtalk217
Update crates/bevy_render/src/world_sync.rs
c25d560 
Co-authored-by: Trashtalk217 <[email protected]>
@re0312 @Trashtalk217
Update crates/bevy_render/src/world_sync.rs
457e83f 
Co-authored-by: Trashtalk217 <[email protected]>
@alice-i-cecile alice-i-cecile added this to the 0.15 milestone Sep 19, 2024
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Breaking-Change A breaking change to Bevy's public API that needs to be noted in a migration guide D-Complex Quite challenging from either a design or technical perspective. Ask for help! C-Needs-Release-Note Work that should be called out in the blog due to impact X-Blessed Has a large architectural impact or tradeoffs, but the design has been endorsed by decision makers S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

It looks like your PR is a breaking change, but you didn't provide a migration guide.

Could you add some context on what users should update when this change get released in a new version of Bevy?
It will be used to help writing the migration guide for the version. Putting it after a ## Migration Guide will help it get automatically picked up by our tooling.

ecoskey
ecoskey suggested changes Sep 20, 2024
View reviewed changes
Copy link

@ecoskey ecoskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny nitpick, otherwise lgtm unless there's significant changes since the last pr

crates/bevy_render/src/extract_component.rs
/// # Warning
/// Components are only extracted for synced entities (for more information see [`WorldSyncPlugin`]).
/// Removing the component from the main world entity, will stop the [`ExtractComponentPlugin`] from extracting that
/// data, but won't remove the corresponding entity in the render world.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// data, but won't remove the corresponding entity in the render world.
/// data, but won't remove the corresponding component in the render world.

@JMS55
Copy link
Contributor

JMS55 commented Sep 20, 2024

It's kinda unfortunate that all my previous comments can't be easily viewed with this new PR. What wasn't implemented/changed that I suggested?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecoskey ecoskey ecoskey requested changes

@alice-i-cecile alice-i-cecile Awaiting requested review from alice-i-cecile

@JMS55 JMS55 Awaiting requested review from JMS55

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Breaking-Change A breaking change to Bevy's public API that needs to be noted in a migration guide C-Needs-Release-Note Work that should be called out in the blog due to impact D-Complex Quite challenging from either a design or technical perspective. Ask for help! S-Needs-Review Needs reviewer attention (from anyone!) to move forward X-Blessed Has a large architectural impact or tradeoffs, but the design has been endorsed by decision makers
Projects
None yet
Milestone
0.15
Development

Successfully merging this pull request may close these issues.

Render world blocking certain ecs developments
5 participants
@Trashtalk217 @JMS55 @ecoskey @alice-i-cecile @re0312