Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract the feedback strings for the non-Free assessments out of the assessments #21567

Open
wants to merge 29 commits into
base: trunk
Choose a base branch
from
Open

Extract the feedback strings for the non-Free assessments out of the assessments #21567

wants to merge 29 commits into from
+975 −697

Commits on Apr 29, 2024

  1. initial steps to tree-shake non-free code

    @FAMarfuaty
    FAMarfuaty committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    e191abf View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Merge branch 'trunk' of github.com:Yoast/wordpress-seo into experimen… 

    …t/do-not-expose-non-free-code
    @FAMarfuaty
    FAMarfuaty committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    d8de8c3 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Merge branch 'trunk' of github.com:Yoast/wordpress-seo into experimen… 

    …t/do-not-expose-non-free-code
    @FAMarfuaty
    FAMarfuaty committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    dbe02f6 View commit details
    Browse the repository at this point in the history

  2. Remove the override of the external analysis

    @FAMarfuaty
    FAMarfuaty committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    588d046 View commit details
    Browse the repository at this point in the history

  3. Extract the feedback strings out of the assessments

    @FAMarfuaty
    FAMarfuaty committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    0190259 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. pass the method to get the feedback string as part of callbacks config

    @FAMarfuaty
    FAMarfuaty committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    c2d6221 View commit details
    Browse the repository at this point in the history

  2. Extract feedback strings out of Text alignment and text title assessm… 

    …ents
    @FAMarfuaty
    FAMarfuaty committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    11a6495 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. Extract the feedback strings out of List assessment

    @FAMarfuaty
    FAMarfuaty committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    7e18208 View commit details
    Browse the repository at this point in the history

  2. Don't register the List assessment via the assessors

    @FAMarfuaty
    FAMarfuaty committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    8f8a182 View commit details
    Browse the repository at this point in the history

  3. Extract the translation strings out of Image ALt and Product SKU asse… 

    …ssments
    @FAMarfuaty
    FAMarfuaty committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    92b82df View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2024

  1. Merge branch 'trunk' of github.com:Yoast/wordpress-seo into experimen… 

    …t/do-not-expose-non-free-code
    @FAMarfuaty
    FAMarfuaty committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    7cd58b3 View commit details
    Browse the repository at this point in the history

  2. Add a method to format strings to Assessment class

    @FAMarfuaty
    FAMarfuaty committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    9a1599c View commit details
    Browse the repository at this point in the history

  3. Improve the default result texts. Now we return a formatted text

    @FAMarfuaty
    FAMarfuaty committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    ca80ed6 View commit details
    Browse the repository at this point in the history

  4. Remove unused config and set the default assessVariants and `should… 

    …ShowEditButton` to false
    @FAMarfuaty
    FAMarfuaty committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    87896f0 View commit details
    Browse the repository at this point in the history

  5. Remove the Product identifiers assessment from the product assessors

    @FAMarfuaty
    FAMarfuaty committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    8f98372 View commit details
    Browse the repository at this point in the history

  6. Extract the translation strings of the Product identifiers assessment… 

    … result from the assessment
    @FAMarfuaty
    FAMarfuaty committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    99f886b View commit details
    Browse the repository at this point in the history

  7. Rename variables to be more precise

    @FAMarfuaty
    FAMarfuaty committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    59f0b84 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Merge branch 'trunk' of github.com:Yoast/wordpress-seo into experimen… 

    …t/do-not-expose-non-free-code
    @FAMarfuaty
    FAMarfuaty committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    818960c View commit details
    Browse the repository at this point in the history

  2. Add unit test

    @FAMarfuaty
    FAMarfuaty committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    ad64442 View commit details
    Browse the repository at this point in the history

  3. Add default value for this._config.callbacks

    @FAMarfuaty
    FAMarfuaty committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    faed5ba View commit details
    Browse the repository at this point in the history

  4. Fix typos in feedback strings

    @FAMarfuaty
    FAMarfuaty committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    3369a92 View commit details
    Browse the repository at this point in the history

  5. Adjust and add unit tests

    @FAMarfuaty
    FAMarfuaty committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    f1d15fa View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Fix typo in feedback string

    @FAMarfuaty
    FAMarfuaty committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    fb5b18e View commit details
    Browse the repository at this point in the history

  2. Adapt unit tests

    @FAMarfuaty
    FAMarfuaty committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    2645991 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Adapt unit test

    @FAMarfuaty
    FAMarfuaty committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    00338a0 View commit details
    Browse the repository at this point in the history

  2. Add unit tests

    @FAMarfuaty
    FAMarfuaty committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    939282e View commit details
    Browse the repository at this point in the history

  3. Fix typo in analysis doc

    @FAMarfuaty
    FAMarfuaty committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    9ad9fb5 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Merge branch 'trunk' of github.com:Yoast/wordpress-seo into experimen… 

    …t/do-not-expose-non-free-code
    @mhkuu
    mhkuu committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    574a515 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Adapt the default feedback string for SKU assessment

    @FAMarfuaty
    FAMarfuaty committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    3a161f4 View commit details
    Browse the repository at this point in the history