-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract the feedback strings for the non-Free assessments out of the assessments #21567
Open
FAMarfuaty
wants to merge
29
commits into
trunk
Choose a base branch
from
experiment/do-not-expose-non-free-code
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t/do-not-expose-non-free-code
…t/do-not-expose-non-free-code
…t/do-not-expose-non-free-code
…ShowEditButton` to false
… result from the assessment
…t/do-not-expose-non-free-code
FAMarfuaty
added
the
changelog: other
Needs to be included in the 'Other' category in the changelog
label
Sep 4, 2024
FAMarfuaty
force-pushed
the
experiment/do-not-expose-non-free-code
branch
from
September 5, 2024 08:00
c68d40e
to
2645991
Compare
Pull Request Test Coverage Report for Build f0a09f8136ed2d4601ffbc45541a50c42c3b2592Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
worker.registerAssessment()
.callbacks.getResultTexts
, for example with text in the form of translation strings.Relevant technical choices:
createAnchorOpeningTag
inside the assessment is now called after the default and custom configs are merged. This is to make sure that customurlTitle
andurlCallToAction
are always turned into an anchor opening tag.urlTitle
andurlCallToAction
:_n()
anymore which can take plural variables. As a result, I decided to change the feedback strings inside the assessment to use generic string that doesn't mention a number.wordpress-seo-premium
,wpseo-woocommerce
andshopify-seo
, the translation strings for the assessments above are provided that contain the number variables.Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Checking translation strings
js/dist/externals/analysis.js
Test premium assessments
Test together with this accompanying PR: https://github.com/Yoast/wordpress-seo-premium/pull/4473
Install and activate Yoast SEO and Yoast SEO Premium
Create a post with at least 15 sentences
Keyphrase distribution
Title
Word complexity
Text alignment
Test product assessments in WooCommerce
Test together with this accompanying PR: https://github.com/Yoast/wpseo-woocommerce/pull/1014. The test instructions specifically for the translation string generation can be found in this PR.
Install and activate Yoast SEO, Yoast SEO Premium, WooCommerce Yoast SEO
Set the site language to English
Create a product
Lists
Image alt tags
Product SKU
Product identifier
Test product assessments and premium assessments in Shopify
Keyphrase distribution
Word complexity
Lists
Image alt tags
Product SKU
Barcode
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo]
, added test instructions for Shopify and attached theShopify
label to this PR.Documentation
Quality assurance
Innovation
innovation
label.Fixes https://github.com/Yoast/lingo-other-tasks/issues/417