-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation for plausibleBeforeDeath and plausibleStartBeforeEnd #543
Conversation
@katy-sadowski, some thoughts while writing the docs: For |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woohooo thanks so much Maxim!
Re: the 60 day buffer - I found the explanation on the Themis docs: https://ohdsi.github.io/Themis/obs_periods_for_ehr.html#observation-period-end-date. I do wonder if this warrants its own general convention for "How to handle events dating after death"? @clairblacketer what do you think? [PS - super exciting to be able to search for and find that on the website 😄 ]
Re: start before end - interesting question. I am torn, because this could cause really serious problems in some cases, maybe even errors in code, so that would be an argument for Fatal. On the other hand I think the intention of Fatal was really database conformance level stuff. @clairblacketer what do you think?
We do have a ratified convention for events after death. It needs to be documented in the Themis convention library. Right now it is just a ratified and closed in the Themis issues OHDSI/Themis#42 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @MaximMoinat !
Maybe we can discuss Fatal vs Convention for StartBeforeEnd at the next DQ call. Can merge in for now and update if we decide to change it later :)
Fixes #541. Needs to be rendered with pkgdown after review.