r check and description updates

OHDSI · May 21, 2024 · 040c2ee · 040c2ee
1 parent 8ad5185
commit 040c2ee
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 8 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -44,7 +44,5 @@ Suggests:
     ggplot2,
     Eunomia,
     R.utils
-Remotes:
-    ohdsi/Eunomia
-RoxygenNote: 7.2.2
+RoxygenNote: 7.3.1
 Encoding: UTF-8
diff --git a/R/runCheck.R b/R/runCheck.R
@@ -17,7 +17,7 @@
 #' Internal function to run and process each data quality check.
 #'
 #' @param checkDescription          The description of the data quality check
-#' @param tablechecks               A dataframe containing the table checks
+#' @param tableChecks               A dataframe containing the table checks
 #' @param fieldChecks               A dataframe containing the field checks
 #' @param conceptChecks             A dataframe containing the concept checks
 #' @param connectionDetails         A connectionDetails object for connecting to the CDM database

diff --git a/R/view.R b/R/view.R
@@ -46,7 +46,7 @@ viewDqDashboard <- function(jsonPath, launch.browser = NULL, display.mode = NULL
 
 # Borrowed from devtools:
 # https://github.com/hadley/devtools/blob/ba7a5a4abd8258c52cb156e7b26bb4bf47a79f0b/R/utils.r#L44
-is_installed <- function(pkg, version = 0) {
+is_installed <- function(pkg, version = "0") {
   installed_version <-
     tryCatch(
       utils::packageVersion(pkg),

diff --git a/man/dot-runCheck.Rd b/man/dot-runCheck.Rd
diff --git a/tests/testthat/test-helpers.R b/tests/testthat/test-helpers.R
@@ -1,6 +1,6 @@
 library(testthat)
 
-test_that("listDqChecks works", {
+test_that("Installation check works", {
   result <- DataQualityDashboard:::is_installed("SqlRender")
   expect_true(result)
   expect_null(DataQualityDashboard:::ensure_installed("SqlRender"))