Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base.seek and Base.skip should return stream #156

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Base.seek and Base.skip should return stream #156

merged 1 commit into from
Oct 16, 2023

Conversation

nhz2
Copy link
Member

@nhz2 nhz2 commented Oct 16, 2023

Continues #115 by having all Base.seek, Base.seekend, Base.seekstart, and Base.skip return the input stream.

See https://github.com/JuliaLang/julia/blob/ae8452a9e0b973991c30f27beb2201db1b0ea0d3/base/iostream.jl#L164

This would make it more of a drop-in replacement for an IOStream.

@nhz2 nhz2 requested a review from jakobnissen October 16, 2023 14:54
jakobnissen
jakobnissen approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@jakobnissen jakobnissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! And thanks for doing this :)

@nhz2 nhz2 merged commit 1cb583d into JuliaIO:master Oct 16, 2023
18 checks passed
@nhz2 nhz2 deleted the skip-fixes branch October 16, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakobnissen jakobnissen jakobnissen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nhz2 @jakobnissen