-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add open for composed transcodingstreams #113
base: master
Are you sure you want to change the base?
Conversation
I'll add tests if anyone with the permission to merge gives me the thumbs-up :) |
function _open(code::Type{<:Type{T}}, io::IO) where {T <: TranscodingStream} | ||
T(io) | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a comment about what this does?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add tests
@jakobnissen If helpful and if you are interested, I can give you commit access here. |
This still needs a test. |
Agree. |
This allows users to easily chain codecs using the do-syntax. Here is an example where the input is chained through four different streams.