Fixed called class check in Widget::end() when widget configured using callable
#20270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20270 +/- ##
============================================
- Coverage 64.84% 64.84% -0.01%
+ Complexity 11401 11399 -2
============================================
Files 430 430
Lines 37138 37137 -1
============================================
- Hits 24083 24080 -3
- Misses 13055 13057 +2 ☔ View full report in Codecov by Sentry. |
samdark
approved these changes
Oct 30, 2024
Arhell
approved these changes
Oct 31, 2024
mtangoo
approved these changes
Oct 31, 2024
|
@jrajamaki thanks for your time and effort! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20267