Skip to content

Commit

Permalink
Merge pull request #186 from kjsanger/feature/irods-4.3.2
Browse files Browse the repository at this point in the history
Add test skip for a bug fixed in iRODS 4.3.2
  • Loading branch information
kjsanger authored May 29, 2024
2 parents eb50134 + fe47418 commit 5aaa9f3
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions tests/test_irods.py
Original file line number Diff line number Diff line change
Expand Up @@ -817,7 +817,8 @@ def test_get_checksum(self, simple_data_object):

@m.it("Can have its checksum verified as good")
@pytest.mark.skipif(
irods_version() <= (4, 2, 10), reason="requires iRODS server >4.2.10"
irods_version() <= (4, 2, 10),
reason=f"requires iRODS server >4.2.10; version is {irods_version()}",
)
def test_verify_checksum_good(self, simple_data_object):
obj = DataObject(simple_data_object)
Expand All @@ -829,7 +830,8 @@ def test_verify_checksum_good(self, simple_data_object):

@m.it("Can have its checksum verified as bad")
@pytest.mark.skipif(
irods_version() <= (4, 2, 10), reason="requires iRODS server >4.2.10"
irods_version() <= (4, 2, 10),
reason=f"requires iRODS server >4.2.10; version is {irods_version()}",
)
def test_verify_checksum_bad(self, invalid_checksum_data_object):
obj = DataObject(invalid_checksum_data_object)
Expand Down Expand Up @@ -1118,6 +1120,10 @@ def test_trim_valid_replica_zero(self, simple_data_object, sql_test_utilities):
with pytest.raises(RodsError, match="trim error"):
obj.trim_replicas(min_replicas=0, valid=True, invalid=False)

@pytest.mark.skipif(
irods_version() >= (4, 3, 2),
reason=f"fixed in iRODS 4.3.2; version is {irods_version()}",
)
@m.describe("Data objects with invalid replicas")
@m.context("When trimming would violate the minimum replica count")
@m.it("Still trims invalid replicas")
Expand Down

0 comments on commit 5aaa9f3

Please sign in to comment.