Add autoflake to Python formatting (#281)

Fixes #280

wpiformat/pyproject.toml

@@ -4,6 +4,7 @@ description = "Linters and formatters for ensuring WPILib's source code conforms
 dynamic = [ "version" ]
 readme = "README.rst"
 dependencies = [
+  "autoflake==2.3.1",
   "black==24.3.0",
   "clang-format==18.1.1",
   "clang-tidy==18.1.1",

wpiformat/wpiformat/licenseupdate.py

@@ -4,7 +4,6 @@
 import os
 import regex
 import subprocess
-import sys
 
 from wpiformat.config import Config
 from wpiformat.task import PipelineTask

wpiformat/wpiformat/lint.py

@@ -8,7 +8,6 @@
 required it to be used as a module.
 """
 
-import os
 import sys
 
 from wpiformat import cpplint
@@ -22,11 +21,6 @@ def should_process_file(config_file, name):
 
     @staticmethod
     def run_batch(config_file, names):
-        # Handle running in either the root or styleguide directories
-        cpplintPrefix = ""
-        if os.getcwd().rpartition(os.sep)[2] != "styleguide":
-            cpplintPrefix = "styleguide/"
-
         # Prepare arguments to cpplint.py
         saved_argv = sys.argv
 

wpiformat/wpiformat/pyformat.py

@@ -13,10 +13,28 @@ def should_process_file(config_file, name):
 
     @staticmethod
     def run_batch(config_file, names):
+        try:
+            args = [
+                sys.executable,
+                "-m",
+                "autoflake",
+                "--remove-all-unused-imports",
+                "--remove-unused-variables",
+                "--quiet",
+                "-i",
+            ]
+            subprocess.run(args + names)
+        except FileNotFoundError:
+            print(
+                "Error: autoflake not found in PATH. Is it installed?", file=sys.stderr
+            )
+            return False
+
         try:
             args = [sys.executable, "-m", "black", "-q"]
             subprocess.run(args + names)
         except FileNotFoundError:
             print("Error: black not found in PATH. Is it installed?", file=sys.stderr)
             return False
+
         return True

wpiformat/wpiformat/stdlib.py

@@ -392,8 +392,6 @@ def func_substitute(header, lines):
         """
         pos = 0
         while pos < len(lines):
-            old_length = len(lines)
-
             # Check for function starting at "pos"
             match = header.func_regex.search(lines, pos)
             if not match:

wpiformat/wpiformat/test/test_licenseupdate.py

@@ -1,7 +1,6 @@
 from datetime import date
 import os
 from pathlib import Path
-import shutil
 import subprocess
 import tempfile
 

wpiformat/wpiformat/test/test_usingdeclaration.py

@@ -1,6 +1,4 @@
-import io
 import os
-import sys
 
 from .test_tasktest import *
 from wpiformat.usingdeclaration import UsingDeclaration

wpiformat/wpiformat/whitespace.py

@@ -1,7 +1,5 @@
 """This task removes trailing whitespace from the file."""
 
-import os
-
 from wpiformat.task import PipelineTask