-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ECE for payment processing on block checkout page #3439
base: develop
Are you sure you want to change the base?
Conversation
@wjrosa I have requested your review as you are also working on ECE issues. Feel free to unassign yourself if you are too occupied 🍫 |
Thanks, @annemirasol for checking this.
I will create a separate issue to handle this scenario. 👀
After disabling the feature flag, try running |
@@ -174,6 +183,7 @@ public function get_payment_method_data() { | |||
return array_replace_recursive( | |||
$this->get_gateway_javascript_params(), | |||
$this->get_payment_request_javascript_params(), | |||
$this->get_express_checkout_javascript_params(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mayisha Had some time to closely look at the empty box/403 forbidden problem I reported earlier, and it looks like it's from this line ^ that's not checking whether ECE is enabled or not before replacing JS (nonce) params
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @annemirasol for the findings 😃
Fixes #3403
Changes proposed in this Pull Request:
Testing instructions
is_stripe_ece_enabled
function or in your database add an option_wcstripe_feature_ece
and set yes as the value).