-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WC Order Attribution data when processing Express Payment button requests #3107
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @james-allan 👋
Thanks for working on this.
The fix is working for shortcode cart and checkout, order attribution data is set properly.
But order attribution data is not set and still showing Unknown
when I purchase from block cart or block checkout. I have used Google Pay for testing.
In the screenshot below, the second order is placed from shortcode checkout which has the origin Direct
and the first order with origin Unknown
is placed from block checkout.
I think we need to make similar changes in https://github.com/woocommerce/woocommerce-gateway-stripe/blob/fix/3022-order-attribution-express-buttons/client/api/blocks.js#L68 to add the attribution data when using block cart/checkout.
Good callout @Mayisha. I've tried to get the block checkout and cart to correctly include order attribution data, however, I'm not sure how to get WC core to either populate the I'm going to put this one on hold for now until we can resolve that. |
Fixes #3022
Changes proposed in this Pull Request:
When a store has Order Attribution data enabled, payments via express payment buttons (Apple Pay, Google Pay etc) were missing this order attribution data.
This PR fixes that by:
<wc-order-attribution-inputs></wc-order-attribution-inputs>
element where ever we include the express payment button.Testing instructions
fix/3022-order-attribution-express-buttons
).changelog.txt
andreadme.txt
(or does not apply)Post merge