-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Baseline Profiles] Test Generation (Without Login) #12429
Draft
ParaskP7
wants to merge
10
commits into
trunk
Choose a base branch
from
test/baseline-profiles-without-login
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParaskP7
added
status: do not merge
Dependent on another PR, ready for review but not ready for merge.
category: tooling
Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc.
Core
labels
Aug 28, 2024
ParaskP7
changed the title
[Baseline Profiles] Test Without Login
[Baseline Profiles] Test Generation (Without Login)
Aug 28, 2024
ParaskP7
force-pushed
the
test/baseline-profiles-without-login
branch
6 times, most recently
from
August 28, 2024 11:23
f920f06
to
9e724d9
Compare
For more info see: - https://developer.android.com/topic/performance/baselineprofiles/ dex-layout-optimizations - https://android-developers.googleblog.com/2023/05/ whats-new-in-jetpack-io-2023.html "The plugin also allows you to easily automate the new Dex Layout Optimization feature in AGP 8.1, which lets you define BaselineProfileRule tests that collect classes used during startup, and move them to the primary dex file in a multidex app to increase locality. In a large app, this can improve cold startup time by 30% on top of Baseline Profiles!"
For more info see: https://developer.android.com/topic/performance/ baselineprofiles/configure-baselineprofiles#store-into-sources
For more info see: https://developer.android.com/topic/performance/ baselineprofiles/configure-baselineprofiles#auto-generate-for-releases
For more info see: https://developer.android.com/topic/performance/ baselineprofiles/debug-baseline-profiles#installation_issues
FYI: This will very likely fail due to managed devices, but I want to test it anyway so that I know how to further progress from here.
In order to use Gradle Managed Devices (GMD) on CI for a particular device, it needs to be installed and its license accepted. ------------------------------------------------------------------------ FYI: After trying that, and without deeper investigation as to why, this attempt fails on CI with the below: [2024-08-28T08:39:58Z] [=== ] 10% Installing Google APIs Intel x86_6 Warning: Failed to read or create install properties file. [2024-08-28T08:39:58Z] 🚨 Error: The command exited with status 1 [2024-08-28T08:39:58Z] user command error: exit status 1 It seems that the installation process does not have the necessary permissions to write to the directory where the SDK is located, thus failing.
…ssemble" This reverts commit 44db206c5800ef845395ba52833318de84c8da8a.
AMI Name: android-build-image-6.12.0v1.2-rc-1 ------------------------------------------------------------------------ FYI: This AMI includes the needed system image, 'system-images; android-34;google_apis;x86_64', which is needed to be able for the release build to use Gradle Managed Devices (GMD) with that particular managed device configuration: testOptions.managedDevices.devices { pixel6Api34(ManagedVirtualDevice) { device = "Pixel 6" apiLevel = 34 systemImageSource = "google" } }
ParaskP7
force-pushed
the
test/baseline-profiles-without-login
branch
from
September 13, 2024 11:56
9e724d9
to
a3343f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category: tooling
Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc.
Core
status: do not merge
Dependent on another PR, ready for review but not ready for merge.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO