Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): Honor the host specified in current docker context #490

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rajiv-k
Copy link

@rajiv-k rajiv-k commented Jan 9, 2024

Thanks for the great tool! ❤️

This patch adds support for detecting the "docker host" to connect to which is set in the current docker context. One can have multiple such contexts and one of them can be activated via docker context use <context-name>.

Fixes: #397 #412 #408

@reegnz
Copy link

reegnz commented Apr 13, 2024

@rajiv-k tests seem to be failing.

@rajiv-k
Copy link
Author

rajiv-k commented Jul 17, 2024

@reegnz I had some time and wanted to look into the failing tests you mentioned. But it looks like the workflow needs approval now.

@jjmaestro
Copy link

I'd also love to get this patch merged, I think it'll be very useful to improve the usability of dive for e.g. Docker + Lima which usually sets up a separate Docker context and the "UX" for the average user without this patch is a pretty confusing failure when trying to fetch an image!

@rajiv-k
Copy link
Author

rajiv-k commented Sep 26, 2024

Hi @wagoodman! Could you please take a look at this PR? I'd be happy to make any changes required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

does not work with colima engine
4 participants