Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new puppet-lint gem #15

Closed
wants to merge 4 commits into from
Closed

Use new puppet-lint gem #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6c81bcf
Using the now-maintained puppetlabs-puppet-lint over puppet-lint
GSPatton Oct 18, 2023
a7fb609
testing with new changes in puppet-lint PR
GSPatton Nov 8, 2023
9ba9e96
fixing rubocop errors
GSPatton Nov 8, 2023
bb25904
fixing some errors
GSPatton Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ group :coverage, optional: ENV['COVERAGE'] != 'yes' do
end

group :development do
gem 'puppetlabs-lint', github: 'puppetlabs/puppet-lint', branch: 'fix-namespace-clash'
gem 'rake', '~> 13.0', '>= 13.0.6'
gem 'rspec', '~> 3.12'
gem 'rspec-collection_matchers', '~> 1.2'
Expand Down
2 changes: 1 addition & 1 deletion puppet-lint-optional_default-check.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@ Gem::Specification.new do |spec|

spec.required_ruby_version = '>= 2.7.0'

spec.add_dependency 'puppet-lint', '>= 3', '< 5'
# spec.add_dependency 'puppet-lint', '>= 3', '< 5'
end
2 changes: 1 addition & 1 deletion spec/spec_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@
]
end

require 'puppet-lint'
require 'puppetlabs/puppetlabs-lint'

PuppetLint::Plugins.load_spec_helper
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this also be updated to have its own namespace? Otherwise you still have the problem of overlapping with the old gem.

Loading