Add -t option to populate managed modules using GitHub's repository topics #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 4, 2018 10:29
ekohl
reviewed
Dec 5, 2018
| def self.managed_modules(config_file, filter, negative_filter, topic) | ||
| if topic | ||
| managed_modules = [] | ||
| GITHUB.org_repos(GITHUB_ORGANIZATION).each do |repo| |
There was a problem hiding this comment.
I'm wondering if managed_modules = GITHUB.org_repos(GITHUB_ORGANIZATION).filter { |r| r.topics.include?(topic) }.map(&:name) is easier to read
| end | ||
|
|
||
| GITHUB = Octokit::Client.new(:access_token => GITHUB_TOKEN) |
There was a problem hiding this comment.
I'm not sure about a global with state. Perhaps it should be a lazy (static) method on the module. This can help in case it's used in an offline context.
|
Interesting! This sounds like driven by the same idea we had for managing GitLab projects with their projects topics. 👍 See our Python CLI package concierge-cli on PyPI for reference. |
neomilium
added a commit
to opus-codium/modulesync
that referenced
this pull request
Apr 21, 2021
This commit renames ModuleSync::PR module to ModuleSync::GitService. Git service classes (ie. GitHub and GitLab) can now be used to implement more features than PR/MR opening. (e.g voxpupuli#158)
neomilium
added a commit
to opus-codium/modulesync
that referenced
this pull request
Apr 21, 2021
This commit renames ModuleSync::PR module to ModuleSync::GitService. Git service classes (ie. GitHub and GitLab) can now be used to implement more features than PR/MR opening. (e.g voxpupuli#158)
neomilium
added a commit
to opus-codium/modulesync
that referenced
this pull request
Apr 21, 2021
This commit renames ModuleSync::PR module to ModuleSync::GitService. Git service classes (ie. GitHub and GitLab) can now be used to implement more features than PR/MR opening. (e.g voxpupuli#158)
neomilium
added a commit
to opus-codium/modulesync
that referenced
this pull request
Apr 22, 2021
This commit renames ModuleSync::PR module to ModuleSync::GitService. Git service classes (ie. GitHub and GitLab) can now be used to implement more features than PR/MR opening. (e.g voxpupuli#158)
neomilium
added a commit
to opus-codium/modulesync
that referenced
this pull request
Apr 23, 2021
This commit renames ModuleSync::PR module to ModuleSync::GitService. Git service classes (ie. GitHub and GitLab) can now be used to implement more features than PR/MR opening. (e.g voxpupuli#158)
neomilium
added a commit
to opus-codium/modulesync
that referenced
this pull request
Apr 23, 2021
This commit renames ModuleSync::PR module to ModuleSync::GitService. Git service classes (ie. GitHub and GitLab) can now be used to implement more features than PR/MR opening. (e.g voxpupuli#158)
neomilium
added a commit
to opus-codium/modulesync
that referenced
this pull request
Apr 23, 2021
This commit renames ModuleSync::PR module to ModuleSync::GitService. Git service classes (ie. GitHub and GitLab) can now be used to implement more features than PR/MR opening. (e.g voxpupuli#158)
neomilium
added a commit
to opus-codium/modulesync
that referenced
this pull request
Apr 23, 2021
This commit renames ModuleSync::PR module to ModuleSync::GitService. Git service classes (ie. GitHub and GitLab) can now be used to implement more features than PR/MR opening. (e.g voxpupuli#158)
Merged
neomilium
added a commit
to opus-codium/modulesync
that referenced
this pull request
Oct 5, 2021
This commit renames ModuleSync::PR module to ModuleSync::GitService. Git service classes (ie. GitHub and GitLab) can now be used to implement more features than PR/MR opening. (e.g voxpupuli#158)
neomilium
added a commit
to opus-codium/modulesync
that referenced
this pull request
Oct 6, 2021
This commit renames ModuleSync::PR module to ModuleSync::GitService. Git service classes (ie. GitHub and GitLab) can now be used to implement more features than PR/MR opening. (e.g voxpupuli#158)
neomilium
added a commit
to opus-codium/modulesync
that referenced
this pull request
Oct 6, 2021
This commit renames ModuleSync::PR module to ModuleSync::GitService. Git service classes (ie. GitHub and GitLab) can now be used to implement more features than PR/MR opening. (e.g voxpupuli#158)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub supports tagging repositories with "topics". This PR leverages this functionality to populate a list of managed modules rather than having to manually maintain
managed_modules.yml.This allows teams to add the topic
rubyto a GitHub repository and then use the-t rubyoption in their Ruby Modulesync CI/CD job to grab all of the repositories to sync.